Bug 229135

Summary:

Make most pseudo elements with display: contents; compute display value to inline by default

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

koivisto, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/w3c/csswg-drafts/issues/6518

Attachments:

Description	Flags
Patch	none

Description Tim Nguyen (:ntim) 2021-08-16 04:31:47 PDT

Except ::before/::after/::file-selector-button where display: contents should just work.

Except ::backdrop where it should compute to block (though this will be handled along with the backdrop + top layer implementation).

Comment 1 Tim Nguyen (:ntim) 2021-08-16 04:32:03 PDT

See also: https://github.com/w3c/csswg-drafts/issues/6518

Comment 2 Radar WebKit Bug Importer 2021-08-23 04:32:15 PDT

<rdar://problem/82239251>

Comment 3 Tim Nguyen (:ntim) 2021-10-15 02:05:21 PDT

Created attachment 441352 [details]
Patch

Comment 4 Antti Koivisto 2021-10-15 02:37:37 PDT

this needs a test

Comment 5 Tim Nguyen (:ntim) 2021-10-15 04:12:36 PDT

(In reply to Antti Koivisto from comment #4)
> this needs a test

Do you know where this case is ever reached? I'm tempted to remove the block if it isn't reached.

Comment 6 Antti Koivisto 2021-10-15 05:37:34 PDT

> Do you know where this case is ever reached? I'm tempted to remove the block
> if it isn't reached.

No, but I would expect that the person who wants to change the code does.

Comment 7 Tim Nguyen (:ntim) 2021-10-15 08:25:16 PDT

Will look into this when I have more time.