Bug 229127

Summary: "make analyze" should run clang static analyzer in deep mode
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, aestes, ap, dino, ews-watchlist, jbedard, kbr, kondapallykalyan, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=68908
https://bugs.webkit.org/show_bug.cgi?id=68910
Bug Depends on:    
Bug Blocks: 229461, 249251    
Attachments:
Description Flags
Patch v1
ap: review+
Patch for landing none

David Kilzer (:ddkilzer)
Reported 2021-08-15 15:26:43 PDT
"make analyze" should run clang static analyzer in deep mode. This is accomplished by passing an "analyze" argument to the "xcodebuild" command, which defaults to deep analysis mode.
Attachments
Patch v1 (20.22 KB, patch)
2021-08-15 15:39 PDT, David Kilzer (:ddkilzer) 		ap: review+
DetailsFormatted DiffDiff
Patch for landing (20.25 KB, patch)
2021-08-16 08:59 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-15 15:27:21 PDT
<rdar://problem/81960587>
David Kilzer (:ddkilzer)
Comment 2 2021-08-15 15:39:13 PDT
Created attachment 435574 [details] Patch v1
EWS Watchlist
Comment 3 2021-08-15 15:40:22 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
David Kilzer (:ddkilzer)
Comment 4 2021-08-16 08:59:55 PDT
Created attachment 435606 [details] Patch for landing
David Kilzer (:ddkilzer)
Comment 5 2021-08-16 09:01:05 PDT
(In reply to David Kilzer (:ddkilzer) from comment #4) > Created attachment 435606 [details] > Patch for landing The only change is to simplify `analyze` target in Makefile.shared.
EWS
Comment 6 2021-08-16 09:31:32 PDT
Committed r281088 (240548@main): <https://commits.webkit.org/240548@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435606 [details].
Note You need to log in before you can comment on or make changes to this bug.