Bug 229100

Summary: Use Vector<SandboxExtension::Handle> instead of SandboxExtension::HandleArray
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, hta, jer.noble, mmaxfield, philipj, sergio, tommyw, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Fix internal build? none

Description Alex Christensen 2021-08-13 15:14:09 PDT 
Use Vector<SandboxExtension::Handle> instead of SandboxExtension::HandleArray
Comment 1 Alex Christensen 2021-08-13 15:15:16 PDT 
Created attachment 435520 [details]
Patch
Comment 2 Chris Dumez 2021-08-19 12:33:32 PDT 
Comment on attachment 435520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435520&action=review

r=me

> Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:428
> +bool SandboxExtension::consumePermanently(const Vector<SandboxExtension::Handle>& handleArray)

Wouldn't `const Vector<Handle>&` work?

> Source/WebKit/Shared/SandboxExtension.h:127
> +inline auto SandboxExtension::createReadOnlyHandlesForFiles(ASCIILiteral, const Vector<String>&) -> Vector<Handle> { return { }; }

Do we need the auto return value here? Wouldn't `Vector<Handle>` as return value work here since we're in the class scope?
Comment 3 Alex Christensen 2021-08-19 12:34:39 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 435520 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435520&action=review
> 
> r=me
> 
> > Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:428
> > +bool SandboxExtension::consumePermanently(const Vector<SandboxExtension::Handle>& handleArray)
> 
> Wouldn't `const Vector<Handle>&` work?
Yes.

> > Source/WebKit/Shared/SandboxExtension.h:127
> > +inline auto SandboxExtension::createReadOnlyHandlesForFiles(ASCIILiteral, const Vector<String>&) -> Vector<Handle> { return { }; }
> 
> Do we need the auto return value here? Wouldn't `Vector<Handle>` as return
> value work here since we're in the class scope?
No, only trailing return values are in the class scope.
Comment 4 Alex Christensen 2021-08-19 13:16:40 PDT 
Created attachment 435896 [details]
Patch
Comment 5 EWS 2021-08-19 16:02:58 PDT 
Committed r281277 (240702@main): <https://commits.webkit.org/240702@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435896 [details].
Comment 6 Radar WebKit Bug Importer 2021-08-19 16:03:58 PDT 
<rdar://problem/82145920>
Comment 7 Wenson Hsieh 2021-08-19 18:43:18 PDT 
Reopening to attach new patch.
Comment 8 Wenson Hsieh 2021-08-19 18:43:19 PDT 
Created attachment 435933 [details]
Fix internal build?
Comment 9 EWS 2021-08-19 19:35:43 PDT 
Committed r281289 (240713@main): <https://commits.webkit.org/240713@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435933 [details].