Bug 229096

Summary: REGRESSION(r281013): broke windows build
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED INVALID    
Severity: Normal CC: aakash_jain, jean-yves.avenard, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229068    
Attachments:
Description Flags
REVERT of r281013 none

WebKit Commit Bot
Reported 2021-08-13 14:10:34 PDT
https://commits.webkit.org/r281013 introduced a regression: broke windows build This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of r281013 (2.05 KB, patch)
2021-08-13 14:10 PDT, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2021-08-13 14:10:39 PDT
Created attachment 435509 [details] REVERT of r281013 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Jean-Yves Avenard [:jya]
Comment 2 2021-08-13 20:15:07 PDT
There is NO way this commit broke windows build. It’s just swapping two existing lines.
Aakash Jain
Comment 3 2021-08-14 12:09:43 PDT
Yeah. See https://bugs.webkit.org/show_bug.cgi?id=229068#c11
Note You need to log in before you can comment on or make changes to this bug.