Bug 229086

Summary:

Unprefix -webkit-text-size-adjust

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

cdumez, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, joepeck, macpherson, mattwoodrow, menard, mifenton, mmaxfield, nileshprajapati, nimajneb0905, ntim, sebastianzartner, simon.fraser, webkit-bug-importer, woodlxf00, youennf, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://drafts.csswg.org/css-size-adjust/

Bug Depends on:

Bug Blocks:

217522

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-

Sam Sneddon [:gsnedders]

Reported 2021-08-13 11:07:24 PDT

I think this already matches the standard property, so I don't think there's any reason not to just unprefix it (with an alias)?

Attachments
Patch (50.15 KB, patch) 2021-11-30 21:23 PST, Matt Woodrow	ews-feeder: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-08-20 11:08:19 PDT

<rdar://problem/82177514>

Matt Woodrow

Comment 2 2021-11-30 21:23:35 PST

Created attachment 445517 [details] Patch

Simon Fraser (smfr)

Comment 3 2021-11-30 21:28:49 PST

Is there a stable enough spec whose behavior we match?

Simon Fraser (smfr)

Comment 4 2021-11-30 21:29:49 PST

Comment on attachment 445517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445517&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3410 > + fprintf(stderr, "Looking up text size adjust\n"); Ooops.

Myles C. Maxfield

Comment 5 2021-11-30 22:08:11 PST

(In reply to Simon Fraser (smfr) from comment #3) > Is there a stable enough spec whose behavior we match? Not really.

Tim Nguyen (:ntim)

Comment 6 2021-12-24 10:39:24 PST Comment hidden (obsolete)

I think this is mostly missing the <percentage> syntax to match the standard: https://drafts.csswg.org/css-size-adjust/#adjustment-control

Tim Nguyen (:ntim)

Comment 7 2021-12-24 10:43:48 PST Comment hidden (obsolete)

Oh wait, actually no, we do support the percentage syntax.

Tim Nguyen (:ntim)

Comment 8 2021-12-24 10:45:15 PST

We should definitely attempt to make the property animatable as one of the WPT show (and the spec as well).

Note You need to log in before you can comment on or make changes to this bug.