| Summary: | Implement ImageSource::filenameExtension for Cario | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | Platform | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, alice.barraclough | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2008-12-17 14:47:21 PST
Created attachment 26102 [details]
patch
Comment on attachment 26102 [details]
patch
Seems a little indirect to return MIME types and then map them to extensions? Why not just return extensions directly?
> Seems a little indirect to return MIME types and then map them to extensions?
> Why not just return extensions directly?
In theory, the extensions vary by platform. On Windows, for example, they are configurable in the registry. I can change this to return the extension directly, if you like.
Created attachment 26112 [details]
alternate patch
Here's an alternate version that skips the mimeType and defines the extension directly. Go ahead an r+ whichever you like better (or r- them both :) )
Comment on attachment 26112 [details]
alternate patch
This is better. Thanks.
r=me
Comment on attachment 26102 [details]
patch
Clearing review patch on this one.
The reason we are mapping MIME type to extension in the CoreGraphics version of this is that we're stuck with the API of ImageIO. |