Bug 229026

Summary: [LFC][IFC] Make mid-word breaking surrogate pair aware
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2021-08-11 21:52:06 PDT
ssia
Attachments
Patch (7.90 KB, patch)
2021-08-11 21:58 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.93 KB, patch)
2021-08-20 18:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-08-11 21:58:57 PDT
Created attachment 435394 [details] Patch
alan
Comment 2 2021-08-12 09:37:44 PDT
Enabling surrogate pairs requires the non-primary font patch where glyphs can stretch the parent inline box.
Radar WebKit Bug Importer
Comment 3 2021-08-18 21:53:23 PDT
<rdar://problem/82109382>
EWS
Comment 4 2021-08-20 15:00:22 PDT
Committed r281341 (240758@main): <https://commits.webkit.org/240758@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435394 [details].
Darin Adler
Comment 5 2021-08-20 15:11:42 PDT
Comment on attachment 435394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435394&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::Layout::TextUtil::midWorkdBreak): s/Workd/Word/g
alan
Comment 6 2021-08-20 15:23:57 PDT
(In reply to Darin Adler from comment #5) > Comment on attachment 435394 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435394&action=review > > > Source/WebCore/ChangeLog:15 > > + (WebCore::Layout::TextUtil::midWorkdBreak): > > s/Workd/Word/g :( thanks.
alan
Comment 7 2021-08-20 18:19:40 PDT
Created attachment 436052 [details] Patch
alan
Comment 8 2021-08-20 18:29:39 PDT
Fix spelling issue
EWS
Comment 9 2021-08-20 21:01:31 PDT
Found 1 new test failure: http/tests/media/modern-media-controls/pip-support/pip-support-live-broadcast.html
EWS
Comment 10 2021-08-21 06:42:56 PDT
Committed r281372 (240787@main): <https://commits.webkit.org/240787@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436052 [details].
Note You need to log in before you can comment on or make changes to this bug.