Support patterns with a wide gamut source

• Component: Canvas
• Status: RESOLVED FIXED

[Cameron McCormack (:heycam)]

.

[Radar WebKit Bug Importer]

<rdar://problem/81828466>

[Cameron McCormack (:heycam)]

This works with GPUP canvas drawing disabled.

[Cameron McCormack (:heycam)]

Created attachment 438009 [details]
Patch including squashed dependencies for EWS

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Cameron McCormack (:heycam)]

Created attachment 438010 [details]
Patch for review, without dependencies (which will fail EWS)

[Sam Weinig]

Comment on attachment 438010 [details]
Patch for review, without dependencies (which will fail EWS)

View in context: https://bugs.webkit.org/attachment.cgi?id=438010&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:469
> +        auto bitmap = ShareableBitmap::createShareable(resultSize, { imageBuffer->colorSpace() });

A great follow up would be to make the ShareableBitmap's configuration colorspace not optional, requiring each callsite to explicitly specify it. This has been a useful pattern in finding places where sRGB is implicit that can otherwise be hard to find.

[Cameron McCormack (:heycam)]

(In reply to Sam Weinig from comment #6)
> A great follow up would be to make the ShareableBitmap's configuration
> colorspace not optional, requiring each callsite to explicitly specify it.
> This has been a useful pattern in finding places where sRGB is implicit that
> can otherwise be hard to find.

Filed bug 230381 for that.

[Cameron McCormack (:heycam)]

Created attachment 438418 [details]
Patch

[Cameron McCormack (:heycam)]

Created attachment 438429 [details]
Patch

[Cameron McCormack (:heycam)]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/30836

[EWS]

Committed r282630 (241787@main): <https://commits.webkit.org/241787@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438429 [details].