Bug 229023

Summary:

Support patterns with a wide gamut source

Product:

WebKit

Reporter:

Cameron McCormack (:heycam) <heycam>

Component:

Canvas

Assignee:

Cameron McCormack (:heycam) <heycam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, benjamin, cdumez, changseok, clopez, cmarcelo, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, jsbell, kondapallykalyan, sam, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/web-platform-tests/wpt/pull/30836

Bug Depends on:

Bug Blocks:

225140

Attachments:

Description	Flags
Patch including squashed dependencies for EWS	none
Patch for review, without dependencies (which will fail EWS)	none
Patch	none
Patch	none

Cameron McCormack (:heycam)

Reported 2021-08-11 21:37:23 PDT

Attachments
Patch including squashed dependencies for EWS (241.16 KB, patch) 2021-09-12 21:22 PDT, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
Patch for review, without dependencies (which will fail EWS) (24.24 KB, patch) 2021-09-12 21:23 PDT, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
Patch (24.23 KB, patch) 2021-09-16 16:44 PDT, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
Patch (24.23 KB, patch) 2021-09-16 19:01 PDT, Cameron McCormack (:heycam)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-08-11 21:40:46 PDT

<rdar://problem/81828466>

Cameron McCormack (:heycam)

Comment 2 2021-08-19 18:11:29 PDT

This works with GPUP canvas drawing disabled.

Cameron McCormack (:heycam)

Comment 3 2021-09-12 21:22:29 PDT

Created attachment 438009 [details] Patch including squashed dependencies for EWS

EWS Watchlist

Comment 4 2021-09-12 21:23:18 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Cameron McCormack (:heycam)

Comment 5 2021-09-12 21:23:41 PDT

Created attachment 438010 [details] Patch for review, without dependencies (which will fail EWS)

Sam Weinig

Comment 6 2021-09-15 09:30:38 PDT

Comment on attachment 438010 [details] Patch for review, without dependencies (which will fail EWS) View in context: https://bugs.webkit.org/attachment.cgi?id=438010&action=review > Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:469 > + auto bitmap = ShareableBitmap::createShareable(resultSize, { imageBuffer->colorSpace() }); A great follow up would be to make the ShareableBitmap's configuration colorspace not optional, requiring each callsite to explicitly specify it. This has been a useful pattern in finding places where sRGB is implicit that can otherwise be hard to find.

Cameron McCormack (:heycam)

Comment 7 2021-09-16 16:41:26 PDT

(In reply to Sam Weinig from comment #6) > A great follow up would be to make the ShareableBitmap's configuration > colorspace not optional, requiring each callsite to explicitly specify it. > This has been a useful pattern in finding places where sRGB is implicit that > can otherwise be hard to find. Filed bug 230381 for that.

Cameron McCormack (:heycam)

Comment 8 2021-09-16 16:44:12 PDT

Created attachment 438418 [details] Patch

Cameron McCormack (:heycam)

Comment 9 2021-09-16 19:01:12 PDT

Created attachment 438429 [details] Patch

Cameron McCormack (:heycam)

Comment 10 2021-09-16 19:02:43 PDT

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/30836

EWS

Comment 11 2021-09-16 19:54:36 PDT

Committed r282630 (241787@main): <https://commits.webkit.org/241787@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438429 [details].

Note You need to log in before you can comment on or make changes to this bug.