Bug 228996

Summary: Cherry-pick ANGLE: Disable SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS workaround
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 223316    
Bug Blocks:    
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Description Kimmo Kinnunen 2021-08-11 04:49:03 PDT 
From 572afd90bd6b1d0ff43553250a361d6ff93be36f Mon Sep 17 00:00:00 2001
From: Kenneth Russell <kbr@chromium.org>
Date: Fri, 29 Jan 2021 22:45:29 -0800
Subject: [PATCH] Disable SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS workaround.

It causes incorrect compilation of some shaders. The original graphics
driver bugs that motivated enabling it have been fixed, at least on
one of the platforms (macOS).

Tested with new WebGL conformance test in
https://github.com/KhronosGroup/WebGL/pull/3214 .


Cannot be cherry-picked before bug 223316 is fixed.

Must be applied locally before fixing bug 223316.
Comment 1 Kimmo Kinnunen 2021-08-11 04:53:59 PDT 
Created attachment 435335 [details]
Patch
Comment 2 EWS Watchlist 2021-08-11 04:54:55 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-08-11 12:35:01 PDT 
Comment on attachment 435335 [details]
Patch

Sounds like there's a bug in the direct-to-MSL translator to fix here; let's defer approving this until that's known to be fixed.
Comment 4 Radar WebKit Bug Importer 2021-08-18 04:50:17 PDT 
<rdar://problem/82071981>