Bug 228986

Summary: ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, capture redundantly
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Kimmo Kinnunen 2021-08-11 02:01:19 PDT 
ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, capture redundantly

These are not used in ANGLE Cocoa and as such should not be compiled.
Comment 1 Kimmo Kinnunen 2021-08-11 02:06:01 PDT 
Created attachment 435329 [details]
Patch
Comment 2 EWS Watchlist 2021-08-11 02:06:45 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-08-11 11:14:46 PDT 
Comment on attachment 435329 [details]
Patch

Looks good to me if everything still builds and runs. While initially integrating ANGLE into WebKit I had difficulty compiling out some of these sources because doing so would have required code changes, so good to see you made it work. r+
Comment 4 EWS 2021-08-12 03:16:29 PDT 
Committed r280959 (240465@main): <https://commits.webkit.org/240465@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435329 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-12 03:17:19 PDT 
<rdar://problem/81838585>