Bug 228986

Summary: ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, capture redundantly
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2021-08-11 02:01:19 PDT
ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, capture redundantly These are not used in ANGLE Cocoa and as such should not be compiled.
Attachments
Patch (77.05 KB, patch)
2021-08-11 02:06 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-08-11 02:06:01 PDT
Created attachment 435329 [details] Patch
EWS Watchlist
Comment 2 2021-08-11 02:06:45 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2021-08-11 11:14:46 PDT
Comment on attachment 435329 [details] Patch Looks good to me if everything still builds and runs. While initially integrating ANGLE into WebKit I had difficulty compiling out some of these sources because doing so would have required code changes, so good to see you made it work. r+
EWS
Comment 4 2021-08-12 03:16:29 PDT
Committed r280959 (240465@main): <https://commits.webkit.org/240465@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435329 [details].
Radar WebKit Bug Importer
Comment 5 2021-08-12 03:17:19 PDT
<rdar://problem/81838585>
Note You need to log in before you can comment on or make changes to this bug.