Bug 228969

Summary:

[GPU Process] REGRESSION: WebContent often crashes when using iCloud photos

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Canvas

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, mmaxfield, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=228665

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	simon.fraser: review+
Patch	none

Said Abou-Hallawa

Reported 2021-08-10 14:12:42 PDT

This will cause the WebProcess to be terminated. It is a remaining work of bug 228665. Right now these call stacks are possible and all of them are wrong. All of them call RemoteRenderingBackendProxy::releaseRemoteResource() while the GPUP is terminated and is being relaunched: NativeImage: WebKit::RemoteRenderingBackendProxy::releaseRemoteResource(WTF::ObjectIdentifier<WebCore::RenderingResourceIdentifierType>, unsigned long long) WebKit::RemoteResourceCacheProxy::releaseNativeImage(WTF::ObjectIdentifier<WebCore::RenderingResourceIdentifierType>) WebCore::NativeImage::~NativeImage() WebCore::DisplayList::DisplayList::clear() WebCore::DisplayList::ImageBuffer<WebKit::ImageBufferShareableMappedIOSurfaceBackend>::clearBackend() WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed() WebKit::RemoteRenderingBackendProxy::gpuProcessConnectionDidClose(WebKit::GPUProcessConnection&) WebKit::GPUProcessConnection::didClose(IPC::Connection&) WTF::Detail::CallableWrapper<IPC::Connection::connectionDidClose()::$_8, void>::call() ImageBuffer: WebKit::RemoteRenderingBackendProxy::releaseRemoteResource(WTF::ObjectIdentifier<WebCore::RenderingResourceIdentifierType>, unsigned long long) WebKit::RemoteResourceCacheProxy::releaseImageBuffer(WTF::ObjectIdentifier<WebCore::RenderingResourceIdentifierType>) WebKit::RemoteImageBufferProxy<WebKit::ImageBufferShareableMappedIOSurfaceBackend>::~RemoteImageBufferProxy() WebKit::RemoteImageBufferProxy<WebKit::ImageBufferShareableMappedIOSurfaceBackend>::~RemoteImageBufferProxy() WebCore::DisplayList::DisplayList::clear() WebCore::DisplayList::ImageBuffer<WebKit::ImageBufferShareableMappedIOSurfaceBackend>::clearBackend() WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed() WebKit::RemoteRenderingBackendProxy::gpuProcessConnectionDidClose(WebKit::GPUProcessConnection&) WebKit::GPUProcessConnection::didClose(IPC::Connection&) WTF::Detail::CallableWrapper<IPC::Connection::connectionDidClose()::$_8, void>::call() Font: WebKit::RemoteRenderingBackendProxy::releaseRemoteResource(WTF::ObjectIdentifier<WebCore::RenderingResourceIdentifierType>, unsigned long long) WebKit::RemoteResourceCacheProxy::clearFontMap() WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed() WebKit::RemoteRenderingBackendProxy::gpuProcessConnectionDidClose(WebKit::GPUProcessConnection&) WebKit::GPUProcessConnection::didClose(IPC::Connection&) WTF::Detail::CallableWrapper<IPC::Connection::connectionDidClose()::$_8, void>::call()

Attachments
Patch (5.99 KB, patch) 2021-08-10 14:27 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (6.11 KB, patch) 2021-08-10 14:43 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (6.07 KB, patch) 2021-08-11 14:12 PDT, Said Abou-Hallawa	simon.fraser: review+	Details Formatted Diff Diff
Patch (7.88 KB, patch) 2021-08-12 12:24 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.