Bug 228929

Summary:

Don't instantiate a SYNotesActivationObserver to just say that it's not active or visible.

Product:

WebKit

Reporter:

Megan Gardner <megan_gardner>

Component:

New Bugs

Assignee:

Megan Gardner <megan_gardner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+
Patch	none

Description Megan Gardner 2021-08-09 15:45:57 PDT

Don't instantiate a SYNotesActivationObserver to just say that it's not active or visible.

Comment 1 Megan Gardner 2021-08-09 15:48:23 PDT

Created attachment 435219 [details]
Patch

Comment 2 Wenson Hsieh 2021-08-09 15:51:07 PDT

Comment on attachment 435219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435219&action=review

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:602
>      if (!m_appHighlightsObserver)
> -        setUpHighlightsObserver();
> +        return false;

Nit - I think you can just remove this early return altogether.

Comment 3 Megan Gardner 2021-08-09 16:25:59 PDT

Created attachment 435224 [details]
Patch

Comment 4 EWS 2021-08-10 10:29:47 PDT

Committed r280850 (240395@main): <https://commits.webkit.org/240395@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435224 [details].

Comment 5 Radar WebKit Bug Importer 2021-08-10 10:40:27 PDT

<rdar://problem/81750820>