| Summary: | ComplexTextController should add runs' initial advances to the previous glyph, not the current glyph | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED WONTFIX | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 228180 | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2021-08-08 16:37:30 PDT
Created attachment 435160 [details]
WIP
Created attachment 435161 [details]
Patch
Looks like fast/text/initial-advance-selected-text.html is failing. We may actually need https://bugs.webkit.org/show_bug.cgi?id=228180. Comment on attachment 435161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435161&action=review > Source/WebCore/ChangeLog:32 > + in first run) Whitespace Right, it looks like CTRunGetInitialBaseAdvance() fixes this. So it looks like both changes have to be made in tandem: 1. Initial advances get added to the previous glyph's advance, not the current glyph's advance 2. The initial advance points to the first glyph's pen position, not to its paint position Let's not do this. Let's instead just delete the complex text codepath. |