Summary: | Rewrite transition layout tests to take advantage of pauseTransitionAtTimeOnElementWithId() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pierre-Olivier Latour <pol> | ||||
Component: | Tools / Tests | Assignee: | Pierre-Olivier Latour <pol> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarrin, mitz, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Pierre-Olivier Latour
2008-12-16 15:17:49 PST
Note that all the transition-end-event-XXX tests do expect the transition end event to fire, so they can't be converted to the pause API. Unfortunately, a number of tests are chaining transitions or interrupt them, so you can't use the new API to speed them up: LayoutTests/transitions/interrupted-all-transition.html LayoutTests/transitions/interrupt-zero-duration.html LayoutTests/transitions/interrupt-transform-transition.html LayoutTests/transitions/change-values-during-transition.html LayoutTests/transitions/retargetted-transition.html LayoutTests/transitions/matched-transform-functions.html LayoutTests/transitions/start-transform-transition.html LayoutTests/transitions/shadow.html Created attachment 26106 [details]
Patch v1
The speed up is not as significant as for the rewrite of the animation tests, but transition tests now take around 19s instead of 24s.
Comment on attachment 26106 [details]
Patch v1
r=me
Sending LayoutTests/ChangeLog Deleting LayoutTests/transitions/end-event-helpers.js Sending LayoutTests/transitions/interrupt-transform-transition-expected.txt Sending LayoutTests/transitions/interrupt-transform-transition.html Sending LayoutTests/transitions/opacity-transition-zindex.html Sending LayoutTests/transitions/start-transform-transition.html Sending LayoutTests/transitions/transform-op-list-match-expected.txt Sending LayoutTests/transitions/transform-op-list-match.html Sending LayoutTests/transitions/transform-op-list-no-match-expected.txt Sending LayoutTests/transitions/transform-op-list-no-match.html Sending LayoutTests/transitions/transition-end-event-all-properties-expected.txt Sending LayoutTests/transitions/transition-end-event-all-properties.html Sending LayoutTests/transitions/transition-end-event-attributes-expected.txt Sending LayoutTests/transitions/transition-end-event-attributes.html Sending LayoutTests/transitions/transition-end-event-container-expected.txt Sending LayoutTests/transitions/transition-end-event-container.html Adding LayoutTests/transitions/transition-end-event-helpers.js Sending LayoutTests/transitions/transition-end-event-left-expected.txt Sending LayoutTests/transitions/transition-end-event-left.html Sending LayoutTests/transitions/transition-end-event-multiple-01-expected.txt Sending LayoutTests/transitions/transition-end-event-multiple-01.html Sending LayoutTests/transitions/transition-end-event-multiple-02-expected.txt Sending LayoutTests/transitions/transition-end-event-multiple-02.html Sending LayoutTests/transitions/transition-end-event-multiple-03-expected.txt Sending LayoutTests/transitions/transition-end-event-multiple-03.html Sending LayoutTests/transitions/transition-end-event-multiple-04-expected.txt Sending LayoutTests/transitions/transition-end-event-multiple-04.html Sending LayoutTests/transitions/transition-end-event-nested-expected.txt Sending LayoutTests/transitions/transition-end-event-nested.html Sending LayoutTests/transitions/transition-end-event-set-none-expected.txt Sending LayoutTests/transitions/transition-end-event-set-none.html Sending LayoutTests/transitions/transition-end-event-transform-expected.txt Sending LayoutTests/transitions/transition-end-event-transform.html Sending LayoutTests/transitions/transition-end-event-window-expected.txt Sending LayoutTests/transitions/transition-end-event-window.html Adding LayoutTests/transitions/transition-test-helpers.js Adding LayoutTests/transitions/transition-timing-function-expected.txt Deleting LayoutTests/transitions/transition-timing-function-software-expected.txt Deleting LayoutTests/transitions/transition-timing-function-software.html Adding LayoutTests/transitions/transition-timing-function.html Sending LayoutTests/transitions/zero-duration-in-list-expected.txt Sending LayoutTests/transitions/zero-duration-in-list.html Transmitting file data ..................................... Committed revision 39384. |