Bug 228894

Summary:

[:has() pseudo-class] Basic support

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

227702

Attachments:

Description	Flags
patch	none

Description Antti Koivisto 2021-08-07 03:17:44 PDT

Basic support for https://drafts.csswg.org/selectors/#has-pseudo

Comment 1 Antti Koivisto 2021-08-07 03:32:46 PDT

Created attachment 435126 [details]
patch

Comment 2 Simon Fraser (smfr) 2021-08-08 08:54:15 PDT

Comment on attachment 435126 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435126&action=review

> Source/WebCore/css/parser/CSSSelectorParser.cpp:286
> +        if (hasScopePseudoClass(*end))

Is end always non-null here?

Comment 3 Antti Koivisto 2021-08-08 09:01:46 PDT

Comment on attachment 435126 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435126&action=review

>> Source/WebCore/css/parser/CSSSelectorParser.cpp:286
>> +        if (hasScopePseudoClass(*end))
> 
> Is end always non-null here?

yeah, the while() condition checks it

Comment 4 Radar WebKit Bug Importer 2021-08-14 03:18:19 PDT

<rdar://problem/81933618>

Comment 5 EWS 2021-08-19 22:15:55 PDT

Committed r281295 (240719@main): <https://commits.webkit.org/240719@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435126 [details].