Bug 228882

Summary:

[LFC][Integration] HTMLTextFormControlElement should use the inline iterator to collect content for wrap=hard

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, koivisto, mifenton, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description zalan 2021-08-06 18:26:41 PDT

see HTMLTextFormControlElement::valueWithHardLineBreaks

Comment 1 zalan 2021-08-06 18:45:34 PDT

Created attachment 435105 [details]
Patch

Comment 2 Antti Koivisto 2021-08-07 06:02:29 PDT

Comment on attachment 435105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435105&action=review

> Source/WebCore/html/HTMLTextFormControlElement.cpp:709
> +        for (; currentLine; currentLine = currentLine.traverseNext()) {

no need for "currentLine =", traverseNext mutates the iterator.

Comment 3 Antti Koivisto 2021-08-07 06:03:59 PDT

Comment on attachment 435105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435105&action=review

> Source/WebCore/html/HTMLTextFormControlElement.cpp:717
> +                currentLine = currentLine.traverseNext();

Same here

Comment 4 Radar WebKit Bug Importer 2021-08-13 18:27:27 PDT

<rdar://problem/81924585>

Comment 5 zalan 2021-08-20 06:04:07 PDT

Created attachment 435978 [details]
Patch

Comment 6 zalan 2021-08-20 14:17:49 PDT

Created attachment 436026 [details]
Patch

Comment 7 EWS 2021-08-20 19:45:05 PDT

Committed r281358 (240773@main): <https://commits.webkit.org/240773@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436026 [details].