Bug 228882

Summary: [LFC][Integration] HTMLTextFormControlElement should use the inline iterator to collect content for wrap=hard
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, koivisto, mifenton, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2021-08-06 18:26:41 PDT
see HTMLTextFormControlElement::valueWithHardLineBreaks
Attachments
Patch (6.96 KB, patch)
2021-08-06 18:45 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.29 KB, patch)
2021-08-20 06:04 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.28 KB, patch)
2021-08-20 14:17 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-08-06 18:45:34 PDT
Created attachment 435105 [details] Patch
Antti Koivisto
Comment 2 2021-08-07 06:02:29 PDT
Comment on attachment 435105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435105&action=review > Source/WebCore/html/HTMLTextFormControlElement.cpp:709 > + for (; currentLine; currentLine = currentLine.traverseNext()) { no need for "currentLine =", traverseNext mutates the iterator.
Antti Koivisto
Comment 3 2021-08-07 06:03:59 PDT
Comment on attachment 435105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435105&action=review > Source/WebCore/html/HTMLTextFormControlElement.cpp:717 > + currentLine = currentLine.traverseNext(); Same here
Radar WebKit Bug Importer
Comment 4 2021-08-13 18:27:27 PDT
<rdar://problem/81924585>
alan
Comment 5 2021-08-20 06:04:07 PDT
Created attachment 435978 [details] Patch
alan
Comment 6 2021-08-20 14:17:49 PDT
Created attachment 436026 [details] Patch
EWS
Comment 7 2021-08-20 19:45:05 PDT
Committed r281358 (240773@main): <https://commits.webkit.org/240773@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436026 [details].
Note You need to log in before you can comment on or make changes to this bug.