Bug 228872

Summary: REGRESSION (r277997): Max-height not applied for image
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: cathiechen <cathiechen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cathiechen, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, rbuis, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://www.drupal.org/project/eu_cookie_compliance/issues/3195373
See Also: https://bugs.webkit.org/show_bug.cgi?id=217529
https://bugs.webkit.org/show_bug.cgi?id=228076
https://bugs.webkit.org/show_bug.cgi?id=228913
Bug Depends on: 228945    
Bug Blocks:    
Attachments:
Description Flags
Broken image
none
Repro
none
wip
none
Patch
none
Patch
none
Patch none

Description zalan 2021-08-06 14:07:04 PDT 
<rdar://81609809>
Comment 1 zalan 2021-08-06 14:07:46 PDT 
This still looks to be broken after https://trac.webkit.org/changeset/280631/webkit
Comment 2 zalan 2021-08-06 14:12:23 PDT 
Created attachment 435086 [details]
Broken image
Comment 3 Antti Koivisto 2021-08-08 23:12:18 PDT 
Created attachment 435167 [details]
Repro
Comment 4 Antti Koivisto 2021-08-09 03:08:06 PDT 
Created attachment 435181 [details]
wip
Comment 5 Antti Koivisto 2021-08-09 05:42:54 PDT 
see bug 228913 for a similar failure without any min/max properties
Comment 6 cathiechen 2021-08-10 01:59:19 PDT 
Created attachment 435248 [details]
Patch
Comment 7 cathiechen 2021-08-10 09:33:23 PDT 
Created attachment 435267 [details]
Patch
Comment 8 cathiechen 2021-08-10 10:23:28 PDT 
Comment on attachment 435267 [details]
Patch

Hi,
I think this patch is ready for review. Thanks:)
Comment 9 Antti Koivisto 2021-08-10 11:09:43 PDT 
Comment on attachment 435267 [details]
Patch

Did you check this fixes the reported site too?
Comment 10 cathiechen 2021-08-10 20:23:22 PDT 
(In reply to Antti Koivisto from comment #9)
> Comment on attachment 435267 [details]
> Patch
> 
> Did you check this fixes the reported site too?

Yes, checked.
The image size is correct now, but the site crashes afterwards.
The crash issue is not related to this change.
I will file a new bug for it.
Comment 11 cathiechen 2021-08-10 20:27:58 PDT 
(In reply to cathiechen from comment #10)
> (In reply to Antti Koivisto from comment #9)
> > Comment on attachment 435267 [details]
> > Patch
> > 
> > Did you check this fixes the reported site too?
> 
> Yes, checked.
> The image size is correct now, but the site crashes afterwards.
> The crash issue is not related to this change.
> I will file a new bug for it.

Filed https://bugs.webkit.org/show_bug.cgi?id=228982
Comment 12 cathiechen 2021-08-10 20:33:15 PDT 
Created attachment 435321 [details]
Patch
Comment 13 EWS 2021-08-11 00:53:15 PDT 
Committed r280889 (240426@main): <https://commits.webkit.org/240426@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435321 [details].
Comment 14 cathiechen 2021-08-12 06:04:22 PDT 
*** Bug 228913 has been marked as a duplicate of this bug. ***
Comment 15 cathiechen 2021-08-12 07:30:31 PDT 
BTW: This test has been added to WPT by https://github.com/web-platform-tests/wpt/pull/29964