Summary: | REGRESSION (r277997): Max-height not applied for image | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||||
Component: | Layout and Rendering | Assignee: | cathiechen <cathiechen> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bfulgham, cathiechen, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, rbuis, simon.fraser, zalan | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
URL: | https://www.drupal.org/project/eu_cookie_compliance/issues/3195373 | ||||||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=217529 https://bugs.webkit.org/show_bug.cgi?id=228076 https://bugs.webkit.org/show_bug.cgi?id=228913 |
||||||||||||||||
Bug Depends on: | 228945 | ||||||||||||||||
Bug Blocks: | |||||||||||||||||
Attachments: |
|
Description
zalan
2021-08-06 14:07:04 PDT
This still looks to be broken after https://trac.webkit.org/changeset/280631/webkit Created attachment 435086 [details]
Broken image
Created attachment 435167 [details]
Repro
Created attachment 435181 [details]
wip
see bug 228913 for a similar failure without any min/max properties Created attachment 435248 [details]
Patch
Created attachment 435267 [details]
Patch
Comment on attachment 435267 [details]
Patch
Hi,
I think this patch is ready for review. Thanks:)
Comment on attachment 435267 [details]
Patch
Did you check this fixes the reported site too?
(In reply to Antti Koivisto from comment #9) > Comment on attachment 435267 [details] > Patch > > Did you check this fixes the reported site too? Yes, checked. The image size is correct now, but the site crashes afterwards. The crash issue is not related to this change. I will file a new bug for it. (In reply to cathiechen from comment #10) > (In reply to Antti Koivisto from comment #9) > > Comment on attachment 435267 [details] > > Patch > > > > Did you check this fixes the reported site too? > > Yes, checked. > The image size is correct now, but the site crashes afterwards. > The crash issue is not related to this change. > I will file a new bug for it. Filed https://bugs.webkit.org/show_bug.cgi?id=228982 Created attachment 435321 [details]
Patch
Committed r280889 (240426@main): <https://commits.webkit.org/240426@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435321 [details]. *** Bug 228913 has been marked as a duplicate of this bug. *** BTW: This test has been added to WPT by https://github.com/web-platform-tests/wpt/pull/29964 |