Bug 228866

Summary: [ews] Ensure file handle is not leaked in loadConfig.py
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225360
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2021-08-06 09:42:05 PDT
Ensure file handle is not leaked in loadConfig.py, for ews and build.webkit.org Similar to https://commits.webkit.org/237299@main
Attachments
Patch (1.94 KB, patch)
2021-08-06 09:43 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-08-06 09:43:15 PDT
Created attachment 435074 [details] Patch
Alexey Proskuryakov
Comment 2 2021-08-06 10:32:27 PDT
Comment on attachment 435074 [details] Patch The change is clearly an improvement, but I'm curious if we actually observed the problem in practice (i.e. observed that garbage collection didn't do it quickly).
Aakash Jain
Comment 3 2021-08-07 13:24:48 PDT
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 435074 [details] > I'm curious if we actually observed the problem in practice. Not really. The motivation for this change was that when the unit-test fail for something, they also print following error about this closed file. This sometimes makes the unit-test failure message ugly and confusing (e.g. https://ews-build.webkit.org/#/builders/20/builds/53092/steps/12/logs/stdio). Stderr: Exception ignored in: <_io.FileIO name='Tools/CISupport/ews-build/config.json' mode='rb' closefd=True> ResourceWarning: unclosed file <_io.TextIOWrapper name='Tools/CISupport/ews-build/config.json' mode='r' encoding='UTF-8'>
EWS
Comment 4 2021-08-07 13:55:31 PDT
Committed r280759 (240344@main): <https://commits.webkit.org/240344@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435074 [details].
Radar WebKit Bug Importer
Comment 5 2021-08-07 13:56:16 PDT
<rdar://problem/81657719>
Note You need to log in before you can comment on or make changes to this bug.