Bug 228854

Summary: Remove inefficient use of HashMap from FormController along with a bit of other streamlining and modernizing
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: FormsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Cameron McCormack (:heycam)
Reported 2021-08-05 19:24:18 PDT
Darin suggested some cleanups in FormController.cpp in https://bugs.webkit.org/show_bug.cgi?id=228724#c15.
Attachments
Patch (33.73 KB, patch)
2021-08-20 18:22 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-12 19:25:18 PDT
<rdar://problem/81880174>
Darin Adler
Comment 2 2021-08-13 05:07:55 PDT
I’ll make those changes myself. Let me know if you’d prefer to do them or already started.
Darin Adler
Comment 3 2021-08-13 05:08:16 PDT
I’m a bit concerned that there may not be enough test coverage for form saving and restoring.
Cameron McCormack (:heycam)
Comment 4 2021-08-13 16:08:05 PDT
I have not started so feel free!
Darin Adler
Comment 5 2021-08-20 18:22:25 PDT
Created attachment 436053 [details] Patch
Darin Adler
Comment 6 2021-08-22 13:20:53 PDT
Passing all the tests and ready for review
Chris Dumez
Comment 7 2021-08-23 07:42:48 PDT
Comment on attachment 436053 [details] Patch r=me
EWS
Comment 8 2021-08-24 11:33:06 PDT
Committed r281505 (240878@main): <https://commits.webkit.org/240878@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436053 [details].
Note You need to log in before you can comment on or make changes to this bug.