| Summary: | ASSERTION FAILED: !m_networkLoad in NetworkResourceLoader::~NetworkResourceLoader() | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||
| Component: | WebKit2 | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, kkinnunen, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 435047 [details]
response-clone-blob-crash-log.txt
MiniBrowser also can reproduce the assertion failure. 1. Applying the test patch 2. Start the test server ./Tools/Scripts/run-webkit-httpd 3. Start Mac Debug MiniBrowser 4. Select File → New WebKit2 Private Window 5. Go to http://127.0.0.1:8000/fetch/keepalive-fetch.html 6. Close the Private Window 7. The assertion fails Created attachment 435052 [details]
Patch
Comment on attachment 435052 [details]
Patch
I think it would be better for the destructor of NetworkSession or something to call NetworkResourceLoader::cleanup on the kept alive loaders
It sounds a good idea. Will try. Thank you. Created attachment 435084 [details]
Patch
Committed r280740 (240326@main): <https://commits.webkit.org/240326@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435084 [details]. |
Created attachment 435046 [details] test patch ASSERTION FAILED: !m_networkLoad in NetworkResourceLoader::~NetworkResourceLoader() 1. Applying the test patch 2. Compile Mac Debug Tools/Scripts/build-webkit --debug 3. Run layout tests ./Tools/Scripts/run-webkit-tests --debug --no-build http/tests/fetch 4. The assertion fails in the next test case of http/tests/fetch/keepalive-fetch.html ASSERTION FAILED: !m_networkLoad /Volumes/Data/webkit/ga/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp(137) : virtual WebKit::NetworkResourceLoader::~NetworkResourceLoader()