Summary: | WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2021-08-05 06:44:53 PDT
Created attachment 434982 [details]
Patch
Comment on attachment 434982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434982&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:341 > + destroyLayers(); > + updateLayersAsNeeded(); There are three status values: "unknown", "rendering", and "failed". Do we really want to destroy the layers every time the status changes? Good point, we should rename it to sampleBufferDisplayLayerStatusFailed. And only call it when rendering fails. Comment on attachment 434982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434982&action=review > Source/WebCore/ChangeLog:3 > + WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash Will this patch fix bug 228759? Created attachment 435005 [details]
Patch
Created attachment 435061 [details]
Patch
(In reply to Peng Liu from comment #6) > Comment on attachment 434982 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434982&action=review > > > Source/WebCore/ChangeLog:3 > > + WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash > > Will this patch fix bug 228759? No, bug 228759 is due to an unrelated regression Committed r280731 (240318@main): <https://commits.webkit.org/240318@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435061 [details]. |