| Summary: | [LFC][IFC] Add support for -webkit-nbsp-mode: space | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2021-08-04 15:54:09 PDT
Created attachment 434947 [details]
Patch
Comment on attachment 434947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434947&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:-54 > - FlowHasWebKitNBSPMode = 1LLU << 14, maybe just leave a hole, like // Unused = 1LLU << 14, to avoid having to shift everything. (In reply to Antti Koivisto from comment #2) > Comment on attachment 434947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434947&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:-54 > > - FlowHasWebKitNBSPMode = 1LLU << 14, > > maybe just leave a hole, like > > // Unused = 1LLU << 14, > > to avoid having to shift everything. Indeed -but I like looking at the shrinking list. > Indeed -but I like looking at the shrinking list.
I like lists full of comments.
Tools/Scripts/svn-apply failed to apply attachment 434947 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 435970 [details]
Patch
Committed r281306 (240726@main): <https://commits.webkit.org/240726@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435970 [details]. |