Bug 228794

Summary: [LFC][Integration] line-clamp is an unsupported CSS property
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2021-08-04 13:15:12 PDT 
we should bail out on line-clamp instead of deprecated flex box (laying out the flex item is ok as long as we don't have to do line clamping -which requires legacy line structures)
Comment 1 zalan 2021-08-04 13:37:01 PDT 
Created attachment 434930 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-08-04 13:43:01 PDT 
Comment on attachment 434930 [details]
Patch

No test coverage?
Comment 3 zalan 2021-08-04 13:44:42 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 434930 [details]
> Patch
> 
> No test coverage?
We do have some line-clamp tests and the test coverage here is whether we still pass them (i.e. we run legacy line layout) or not.
Comment 4 zalan 2021-08-05 16:09:20 PDT 
Created attachment 435037 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2021-08-11 13:16:18 PDT 
<rdar://problem/81809991>
Comment 6 EWS 2021-08-20 05:49:55 PDT 
Committed r281308 (240728@main): <https://commits.webkit.org/240728@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435037 [details].