Bug 228766

Summary: [Cocoa] Tweak the formatting for passing NSArrays to TextStreams
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dino, ews-watchlist, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 228764    
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+, ews-feeder: commit-queue-

Myles C. Maxfield
Reported 2021-08-03 22:30:05 PDT
[Cocoa] Tweak the formatting for passing NSArrays to TextStreams
Attachments
Patch (10.18 KB, patch)
2021-08-03 22:31 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (11.31 KB, patch)
2021-08-04 00:48 PDT, Myles C. Maxfield 		simon.fraser: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-08-03 22:31:06 PDT
Created attachment 434886 [details] Patch
Myles C. Maxfield
Comment 2 2021-08-04 00:48:39 PDT
Created attachment 434891 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-08-04 08:56:44 PDT
Comment on attachment 434891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434891&action=review > Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.mm:71 > + // Intentionally don't cast to id<NSObject> because we want to make sure that this can be called from raw C++ code. But this is a .mm file so is being complied as ObjC++. Wouldn't a proper test be in a .cpp file?
Myles C. Maxfield
Comment 4 2021-08-04 12:37:47 PDT
Committed r280651 (240262@main): <https://commits.webkit.org/240262@main>
Radar WebKit Bug Importer
Comment 5 2021-08-04 12:38:18 PDT
<rdar://problem/81528316>
Note You need to log in before you can comment on or make changes to this bug.