| Summary: | [Cocoa] Tweak the formatting for passing NSArrays to TextStreams | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dino, ews-watchlist, jonlee, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 228764 | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2021-08-03 22:30:05 PDT
Created attachment 434886 [details]
Patch
Created attachment 434891 [details]
Patch
Comment on attachment 434891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434891&action=review > Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.mm:71 > + // Intentionally don't cast to id<NSObject> because we want to make sure that this can be called from raw C++ code. But this is a .mm file so is being complied as ObjC++. Wouldn't a proper test be in a .cpp file? Committed r280651 (240262@main): <https://commits.webkit.org/240262@main> |