| Summary: | [WebIDL] DOM constructors should extend InternalFunction | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||||
| Component: | Bindings | Assignee: | Alexey Shvayka <ashvayka> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Trivial | CC: | alecflett, beidson, cdumez, darin, ews-watchlist, jsbell, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 216816, 230584 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexey Shvayka
2021-08-03 18:39:50 PDT
Created attachment 434876 [details]
Patch
Comment on attachment 434876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434876&action=review > Source/WebCore/bindings/js/JSDOMConstructorBase.h:22 > #include "JSDOMWrapper.h" Is this still needed? This is great!! Created attachment 438894 [details]
Patch
Remove extra #include, improve ChangeLog, and add a FIXME regarding m_originalName / property order.
Created attachment 438895 [details] Microbenchmark trunk: 188.3ms patch: 155.5ms (17.5% faster) --- 4 runs, sampled around r280750. Comment on attachment 438894 [details]
Patch
Thanks for review and feedback!
Committed r282864 (241995@main): <https://commits.webkit.org/241995@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438894 [details]. *** Bug 210688 has been marked as a duplicate of this bug. *** |