Bug 228763

Summary: [WebIDL] DOM constructors should extend InternalFunction
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: BindingsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Trivial CC: alecflett, beidson, cdumez, darin, ews-watchlist, jsbell, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 216816, 230584    
Attachments:
Description Flags
Patch
none
Patch
none
Microbenchmark none

Alexey Shvayka
Reported 2021-08-03 18:39:50 PDT
[WebIDL] DOM constructors should extend InternalFunction
Attachments
Patch (129.15 KB, patch)
2021-08-03 18:45 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (131.18 KB, patch)
2021-09-21 17:34 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Microbenchmark (770 bytes, text/html)
2021-09-21 17:38 PDT, Alexey Shvayka 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-08-03 18:45:08 PDT
Created attachment 434876 [details] Patch
Sam Weinig
Comment 2 2021-08-04 11:43:12 PDT
Comment on attachment 434876 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434876&action=review > Source/WebCore/bindings/js/JSDOMConstructorBase.h:22 > #include "JSDOMWrapper.h" Is this still needed?
Yusuke Suzuki
Comment 3 2021-08-06 00:53:11 PDT
This is great!!
Radar WebKit Bug Importer
Comment 4 2021-08-10 18:40:19 PDT
<rdar://problem/81771534>
Alexey Shvayka
Comment 5 2021-09-21 17:34:09 PDT
Created attachment 438894 [details] Patch Remove extra #include, improve ChangeLog, and add a FIXME regarding m_originalName / property order.
Alexey Shvayka
Comment 6 2021-09-21 17:38:25 PDT
Created attachment 438895 [details] Microbenchmark trunk: 188.3ms patch: 155.5ms (17.5% faster) --- 4 runs, sampled around r280750.
Alexey Shvayka
Comment 7 2021-09-21 21:19:14 PDT
Comment on attachment 438894 [details] Patch Thanks for review and feedback!
EWS
Comment 8 2021-09-21 21:56:05 PDT
Committed r282864 (241995@main): <https://commits.webkit.org/241995@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438894 [details].
Alexey Shvayka
Comment 9 2023-09-27 14:00:54 PDT
*** Bug 210688 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.