Bug 228741

Summary:

[check-github-mirror-integrity] Handle slow Svn query

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Jonathan Bedard 2021-08-03 10:08:06 PDT

Querying Svn for a commit is slow, and because we query Svn before GitHub, it's possible that GitHub is ahead of Svn. This breaks our logic in check-github-mirror-integrity, which only expects GitHub to be behind Svn. If we reverse the order we fetch commits in, we shouldn't have this problem.

Comment 1 Jonathan Bedard 2021-08-03 10:11:53 PDT

Created attachment 434838 [details]
Patch

Comment 2 Jonathan Bedard 2021-08-03 10:18:24 PDT

Created attachment 434839 [details]
Patch for landing

Comment 3 Radar WebKit Bug Importer 2021-08-03 10:20:05 PDT

<rdar://problem/81467944>

Comment 4 EWS 2021-08-03 10:49:12 PDT

Committed r280602 (240220@main): <https://commits.webkit.org/240220@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434839 [details].