Bug 228716 – Web Inspector: [AppleWin] Speculative internal build fix for copying `InspectorBackendCommands.js`

• Component: Web Inspector
• Status: RESOLVED FIXED

[Patrick Angle]

<rdar://81329155>

[Patrick Angle]

Created attachment 434789 [details]
Patch v1.0

[Per Arne Vollan]

Comment on attachment 434789 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=434789&action=review

> Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.pl:78
> +my $jsFrom = File::Spec->catfile(File::Spec->catdir($ENV{'JAVASCRIPTCORE_PRIVATE_HEADERS_DIR'}, 'inspector'), 'InspectorBackendCommands.js');

Has this file changed location in the JavaScriptCore build?

[Patrick Angle]

Comment on attachment 434789 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=434789&action=review

>> Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.pl:78
>> +my $jsFrom = File::Spec->catfile(File::Spec->catdir($ENV{'JAVASCRIPTCORE_PRIVATE_HEADERS_DIR'}, 'inspector'), 'InspectorBackendCommands.js');
> 
> Has this file changed location in the JavaScriptCore build?

Not any time recently, no. It has been in the `.../inspector/` folder for some time, and this script didn't take that into account. Technically, it didn't affect the build before because in `WebInspectorUI.make` the path was just completely hard coded again anyways, which left the print statement below both wrong and unhelpful. The fix on this line brings the logging in line with the actual command we run later in `WebInspectorUI.make` with the `JAVASCRIPTCORE_PRIVATE_HEADERS_DIR` environment variable.

[Maciej Stachowiak]

Comment on attachment 434789 [details]
Patch v1.0

I'm not totally clear on why this broke or why this change fixes it, but it seems reasonable to try.

[Maciej Stachowiak]

Comment on attachment 434789 [details]
Patch v1.0

Marking CQ+ so we can test this speculative fix ASAP.

[EWS]

Committed r280574 (240196@main): <https://commits.webkit.org/240196@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434789 [details].