Bug 228707

Summary:

Add basestring compatibility for Python3 in webkitcorepy

Product:

WebKit

Reporter:

Russell Epstein <repstein>

Component:

Tools / Tests

Assignee:

Russell Epstein <repstein>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Russell Epstein 2021-08-02 10:57:56 PDT

We should add basestring to webkitcorepy to improve python2-3 compatibility.

Comment 1 Russell Epstein 2021-08-02 11:06:12 PDT

Created attachment 434772 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2021-08-02 11:07:04 PDT

<rdar://problem/81420233>

Comment 3 Jonathan Bedard 2021-08-02 11:10:39 PDT

Comment on attachment 434772 [details]
Patch

Might want to bump the version numbers in webkitcorepy/setup.py and webkitcorepy/__init__.py

Comment 4 Russell Epstein 2021-08-02 11:15:44 PDT

Created attachment 434774 [details]
Patch

Comment 5 EWS 2021-08-02 12:54:31 PDT

Committed r280550 (240177@main): <https://commits.webkit.org/240177@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434774 [details].