Bug 228694

Summary:

Crash in -[WKFullScreenWindowController windowDidExitFullScreen:]

Product:

WebKit

Reporter:

Jean-Yves Avenard [:jya] <jean-yves.avenard>

Component:

New Bugs

Assignee:

Jean-Yves Avenard [:jya] <jean-yves.avenard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

227243

Attachments:

Description	Flags
Patch	none

Description Jean-Yves Avenard [:jya] 2021-08-01 18:30:24 PDT

Crash in -[WKFullScreenWindowController windowDidExitFullScreen:]

Comment 1 Jean-Yves Avenard [:jya] 2021-08-01 18:31:52 PDT

rdar://80727568

Comment 2 Jean-Yves Avenard [:jya] 2021-08-01 18:51:03 PDT

Regression appears to have been introduced by bug 227243.

In the method 
-[WKFullScreenWindowController windowDidExitFullScreen:] 

it seems that the call to [self finishedExitFullScreenAnimation:YES]; delete self.

Comment 3 Jean-Yves Avenard [:jya] 2021-08-01 19:22:10 PDT

Created attachment 434730 [details]
Patch

Comment 4 EWS 2021-08-02 16:19:25 PDT

Committed r280568 (240192@main): <https://commits.webkit.org/240192@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434730 [details].

Comment 5 Darin Adler 2021-08-02 17:39:14 PDT

Comment on attachment 434730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434730&action=review

> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:691
> +    RetainPtr<WKFullScreenWindowController> retain = self;

In future we should be able to omit the template arguments:

    RetainPtr retain = self;