Bug 228694

Summary: Crash in -[WKFullScreenWindowController windowDidExitFullScreen:]
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: New BugsAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 227243    
Attachments:
Description Flags
Patch none

Jean-Yves Avenard [:jya]
Reported 2021-08-01 18:30:24 PDT
Crash in -[WKFullScreenWindowController windowDidExitFullScreen:]
Attachments
Patch (3.95 KB, patch)
2021-08-01 19:22 PDT, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jean-Yves Avenard [:jya]
Comment 1 2021-08-01 18:31:52 PDT
rdar://80727568
Jean-Yves Avenard [:jya]
Comment 2 2021-08-01 18:51:03 PDT
Regression appears to have been introduced by bug 227243. In the method -[WKFullScreenWindowController windowDidExitFullScreen:] it seems that the call to [self finishedExitFullScreenAnimation:YES]; delete self.
Jean-Yves Avenard [:jya]
Comment 3 2021-08-01 19:22:10 PDT
Created attachment 434730 [details] Patch
EWS
Comment 4 2021-08-02 16:19:25 PDT
Committed r280568 (240192@main): <https://commits.webkit.org/240192@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434730 [details].
Darin Adler
Comment 5 2021-08-02 17:39:14 PDT
Comment on attachment 434730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434730&action=review > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:691 > + RetainPtr<WKFullScreenWindowController> retain = self; In future we should be able to omit the template arguments: RetainPtr retain = self;
Note You need to log in before you can comment on or make changes to this bug.