Summary: | [JSC] Yarr should use Bitmap instead of ByteVector for BoyerMoore search | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2021-07-31 00:05:47 PDT
Created attachment 434690 [details]
Patch
Created attachment 434691 [details]
Patch
Created attachment 434692 [details]
Patch
Created attachment 434703 [details]
Patch
Comment on attachment 434703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434703&action=review > Source/JavaScriptCore/yarr/YarrJIT.cpp:2428 > + auto matched = branchTestBit64(NonZero, regT2, regT0); // We can ignore upper bits since module-64 is performed. module->modulo The instruction itself performs modulo 64? r=me Comment on attachment 434703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434703&action=review Thanks! >> Source/JavaScriptCore/yarr/YarrJIT.cpp:2428 >> + auto matched = branchTestBit64(NonZero, regT2, regT0); // We can ignore upper bits since module-64 is performed. > > module->modulo > > The instruction itself performs modulo 64? Yes. https://www.felixcloutier.com/x86/bt Committed r280544 (240171@main): <https://commits.webkit.org/240171@main> |