Summary: | [git-webkit] Color `log` output | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aakash_jain, dewei_zhu, ryanhaddad, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=228027 | ||||||||||||
Bug Depends on: | 228597 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Jonathan Bedard
2021-07-30 14:57:19 PDT
Created attachment 434668 [details]
Patch
Created attachment 434871 [details]
Patch
Created attachment 434915 [details]
Patch
Comment on attachment 434915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434915&action=review r=me > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:73 > + if not isinstance(target, io.IOBase) and not isinstance(target, file) and not isinstance(target, StringIO): This can be simplified as `if not isinstance(target, [io.IOBase, file, StringIO]):` > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:94 > + if not isinstance(target, io.IOBase) and not isinstance(target, file) and not isinstance(target, StringIO): ditto Created attachment 435285 [details]
Patch for landing
Committed r280864 (240404@main): <https://commits.webkit.org/240404@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435285 [details]. |