Bug 228662

Summary:

[git-webkit] Color `log` output

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, dewei_zhu, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=228027

Bug Depends on:

228597

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none

Jonathan Bedard

Reported 2021-07-30 14:57:19 PDT

Some folks want to retain the colored output `git log` provides in `git-webkit log`.

Attachments
Patch (18.91 KB, patch) 2021-07-30 15:02 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (18.91 KB, patch) 2021-08-03 16:52 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (17.23 KB, patch) 2021-08-04 11:14 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch for landing (20.14 KB, patch) 2021-08-10 14:08 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-07-30 14:57:34 PDT

<rdar://problem/81344181>

Jonathan Bedard

Comment 2 2021-07-30 15:02:48 PDT

Created attachment 434668 [details] Patch

Jonathan Bedard

Comment 3 2021-08-03 16:52:41 PDT

Created attachment 434871 [details] Patch

Jonathan Bedard

Comment 4 2021-08-04 11:14:05 PDT

Created attachment 434915 [details] Patch

dewei_zhu

Comment 5 2021-08-10 13:11:39 PDT

Comment on attachment 434915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434915&action=review r=me > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:73 > + if not isinstance(target, io.IOBase) and not isinstance(target, file) and not isinstance(target, StringIO): This can be simplified as `if not isinstance(target, [io.IOBase, file, StringIO]):` > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:94 > + if not isinstance(target, io.IOBase) and not isinstance(target, file) and not isinstance(target, StringIO): ditto

Jonathan Bedard

Comment 6 2021-08-10 14:08:36 PDT

Created attachment 435285 [details] Patch for landing

EWS

Comment 7 2021-08-10 14:35:39 PDT

Committed r280864 (240404@main): <https://commits.webkit.org/240404@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435285 [details].

Note You need to log in before you can comment on or make changes to this bug.