Bug 228662

Summary: [git-webkit] Color `log` output
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=228027
Bug Depends on: 228597    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Jonathan Bedard 2021-07-30 14:57:19 PDT
Some folks want to retain the colored output `git log` provides in `git-webkit log`.
Comment 1 Radar WebKit Bug Importer 2021-07-30 14:57:34 PDT
<rdar://problem/81344181>
Comment 2 Jonathan Bedard 2021-07-30 15:02:48 PDT
Created attachment 434668 [details]
Patch
Comment 3 Jonathan Bedard 2021-08-03 16:52:41 PDT
Created attachment 434871 [details]
Patch
Comment 4 Jonathan Bedard 2021-08-04 11:14:05 PDT
Created attachment 434915 [details]
Patch
Comment 5 dewei_zhu 2021-08-10 13:11:39 PDT
Comment on attachment 434915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434915&action=review

r=me

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:73
> +        if not isinstance(target, io.IOBase) and not isinstance(target, file) and not isinstance(target, StringIO):

This can be simplified as `if not isinstance(target, [io.IOBase, file, StringIO]):`

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:94
> +        if not isinstance(target, io.IOBase) and not isinstance(target, file) and not isinstance(target, StringIO):

ditto
Comment 6 Jonathan Bedard 2021-08-10 14:08:36 PDT
Created attachment 435285 [details]
Patch for landing
Comment 7 EWS 2021-08-10 14:35:39 PDT
Committed r280864 (240404@main): <https://commits.webkit.org/240404@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435285 [details].