Bug 228634

Summary: AVVideoCaptureSource should not start/stop the camera if trying to apply the same size/frame rate configuration
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, msach22, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2021-07-30 03:11:26 PDT
<rdar://81174160>
Attachments
Patch (4.16 KB, patch)
2021-07-30 03:20 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.15 KB, patch)
2021-07-30 09:44 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-30 03:11:42 PDT
<rdar://problem/81317554>
youenn fablet
Comment 2 2021-07-30 03:20:20 PDT
Created attachment 434613 [details] Patch
Eric Carlson
Comment 3 2021-07-30 08:25:49 PDT
Comment on attachment 434613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434613&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:333 > + ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER, " settings already matching"); s/matching/match/
youenn fablet
Comment 4 2021-07-30 09:44:08 PDT
Created attachment 434639 [details] Patch for landing
EWS
Comment 5 2021-07-31 09:53:17 PDT
Committed r280517 (240149@main): <https://commits.webkit.org/240149@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434639 [details].
youenn fablet
Comment 6 2021-08-02 02:13:30 PDT
*** Bug 227933 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.