Bug 228634

Summary:

AVVideoCaptureSource should not start/stop the camera if trying to apply the same size/frame rate configuration

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, hta, jer.noble, msach22, philipj, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description youenn fablet 2021-07-30 03:11:26 PDT

<rdar://81174160>

Comment 1 Radar WebKit Bug Importer 2021-07-30 03:11:42 PDT

<rdar://problem/81317554>

Comment 2 youenn fablet 2021-07-30 03:20:20 PDT

Created attachment 434613 [details]
Patch

Comment 3 Eric Carlson 2021-07-30 08:25:49 PDT

Comment on attachment 434613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434613&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:333
> +        ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER, " settings already matching");

s/matching/match/

Comment 4 youenn fablet 2021-07-30 09:44:08 PDT

Created attachment 434639 [details]
Patch for landing

Comment 5 EWS 2021-07-31 09:53:17 PDT

Committed r280517 (240149@main): <https://commits.webkit.org/240149@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434639 [details].

Comment 6 youenn fablet 2021-08-02 02:13:30 PDT

*** Bug 227933 has been marked as a duplicate of this bug. ***