| Summary: | [Media Controls] Add an option for having no scrubber on the time control and parameterize margin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | Media | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, joepeck, philipj, sergio, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2021-07-30 01:09:00 PDT
Created attachment 434611 [details]
Patch
Comment on attachment 434611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434611&action=review > Source/WebCore/Modules/modern-media-controls/controls/slider.js:147 > + if (style === Slider.KnobStyle.Bar) Normally I would say "use `case` so you force people adding new styles to come back here and make a decision", but JavaScript is all loosey goosey so it doesn't really matter? > Source/WebCore/Modules/modern-media-controls/controls/slider.js:225 > + None: "none" maintain the trailing comma? :D Committed r280477 (240112@main): <https://commits.webkit.org/240112@main> |