Bug 228631

Summary: RemoteAudioMediaStreamTrackRendererInternalUnit should handle changes of requested sampleCount
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2021-07-30 00:14:07 PDT 
RemoteAudioMediaStreamTrackRendererInternalUnit should handle changes of requested sampleCount
Comment 1 youenn fablet 2021-07-30 00:18:07 PDT 
<rdar://80690191>
Comment 2 youenn fablet 2021-07-30 00:25:48 PDT 
Created attachment 434609 [details]
Patch
Comment 3 Eric Carlson 2021-07-30 08:32:15 PDT 
Comment on attachment 434609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434609&action=review

> Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:182
> +    uint64_t requestedSamplesCount = m_generateOffset;

Nit: could be `auto`
Comment 4 Simon Fraser (smfr) 2021-07-30 09:11:07 PDT 
Comment on attachment 434609 [details]
Patch

Can this be tested?
Comment 5 youenn fablet 2021-07-30 09:43:55 PDT 
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 434609 [details]
> Patch
> 
> Can this be tested?

I tested it manually but there is no easy way to test it automatically.
Comment 6 youenn fablet 2021-07-30 09:48:26 PDT 
Created attachment 434640 [details]
Patch for landing
Comment 7 Simon Fraser (smfr) 2021-07-30 10:56:38 PDT 
(In reply to youenn fablet from comment #5)
> (In reply to Simon Fraser (smfr) from comment #4)
> > Comment on attachment 434609 [details]
> > Patch
> > 
> > Can this be tested?
> 
> I tested it manually but there is no easy way to test it automatically.

Can we file a bug to create a mechanism for testing this kind of audio stuff?
Comment 8 youenn fablet 2021-07-31 09:49:32 PDT 
(In reply to Simon Fraser (smfr) from comment #7)
> (In reply to youenn fablet from comment #5)
> > (In reply to Simon Fraser (smfr) from comment #4)
> > > Comment on attachment 434609 [details]
> > > Patch
> > > 
> > > Can this be tested?
> > 
> > I tested it manually but there is no easy way to test it automatically.
> 
> Can we file a bug to create a mechanism for testing this kind of audio stuff?

I filed https://bugs.webkit.org/show_bug.cgi?id=228680
Comment 9 EWS 2021-07-31 09:52:52 PDT 
Committed r280516 (240148@main): <https://commits.webkit.org/240148@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434640 [details].