Bug 228621 – [git-webkit] Forward errors from log and blame

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

We should forward errors from `git/svn log/blame` commands.

[Radar WebKit Bug Importer]

<rdar://problem/81297642>

[Jonathan Bedard]

Created attachment 434628 [details]
Patch

[Aakash Jain]

Comment on attachment 434628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434628&action=review

rs=me

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:258
> +            if not log_output.returncode:

Might be more clear to explicitly compare with 0

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:260
> +                    sys.stderr.write(line)

why not print? Also, can you avoid this for loop and directly print whole thing in a single statement?

[Jonathan Bedard]

(In reply to Aakash Jain from comment #3)
> Comment on attachment 434628 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434628&action=review
> 
> rs=me
> 
> > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:258
> > +            if not log_output.returncode:
> 
> Might be more clear to explicitly compare with 0

It might be 'None', particularly for `git log` or `svn log`

> 
> > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:260
> > +                    sys.stderr.write(line)
> 
> why not print? Also, can you avoid this for loop and directly print whole
> thing in a single statement?

[Jonathan Bedard]

Created attachment 434643 [details]
Patch for landing

[EWS]

Committed r280483 (240118@main): <https://commits.webkit.org/240118@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434643 [details].