Bug 228620

Summary: [macOS|AS] VTImageRotationSession returns a kVTImageRotationNotSupportedErr, breaks painting rotated videos
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 228560    
Attachments:
Description Flags
Patch
pvollan: review+
Patch for landing none

Jer Noble
Reported 2021-07-29 16:15:17 PDT
[macOS|AS] VTImageRotationSession returns a kVTImageRotationNotSupportedErr, breaks painting rotated videos
Attachments
Patch (1.53 KB, patch)
2021-07-29 16:23 PDT, Jer Noble 		pvollan: review+
DetailsFormatted DiffDiff
Patch for landing (1.41 KB, patch)
2021-07-29 17:02 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-07-29 16:23:28 PDT
Created attachment 434586 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-07-29 16:39:33 PDT
<rdar://problem/81297600>
Per Arne Vollan
Comment 3 2021-07-29 16:46:44 PDT
Comment on attachment 434586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434586&action=review > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:124 > + (iokit-registry-entry-class "IOSurfaceAcceleratorClient")) I think it would be good to add a check for the CPU type.
Per Arne Vollan
Comment 4 2021-07-29 16:47:48 PDT
Comment on attachment 434586 [details] Patch R=me, with a CPU check.
Jer Noble
Comment 5 2021-07-29 17:02:32 PDT
Created attachment 434591 [details] Patch for landing
EWS
Comment 6 2021-07-29 19:32:33 PDT
Committed r280465 (240100@main): <https://commits.webkit.org/240100@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434591 [details].
Note You need to log in before you can comment on or make changes to this bug.