Bug 22859

Summary: Abstract away the use of JSDOMWindow in CachedPage and introduce ScriptCachedPageData abstraction.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: WebKit Misc.Assignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
ScriptCachedPageData v1
none
ScriptCachedPageData v2 (added domWindow accessor)
none
ScriptCachedPageData v2.1 (added added bug URL) ggaren: review+

Dimitri Glazkov (Google)
Reported 2008-12-14 18:10:06 PST
I basically followed the same pattern as CachedPagePlatformData. Granted, this change only marginally improves separation of concerns, but it helps tremendously with the unforking.
Attachments
ScriptCachedPageData v1 (15.42 KB, patch)
2008-12-14 18:11 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
ScriptCachedPageData v2 (added domWindow accessor) (15.86 KB, patch)
2008-12-16 10:36 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
ScriptCachedPageData v2.1 (added added bug URL) (15.91 KB, patch)
2008-12-16 10:38 PST, Dimitri Glazkov (Google) 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2008-12-14 18:11:45 PST
Created attachment 26017 [details] ScriptCachedPageData v1 ScriptCachedPageData is a bit verbose, but I tried to stick with both Script prefix convention from existing JS abstractions and Data suffix convention of CachedPagePlatformData.
Dimitri Glazkov (Google)
Comment 2 2008-12-16 10:36:40 PST
Created attachment 26054 [details] ScriptCachedPageData v2 (added domWindow accessor) Rebased to trunk, added domWindow accessor per recent changes to CachedPage
Dimitri Glazkov (Google)
Comment 3 2008-12-16 10:38:19 PST
Created attachment 26055 [details] ScriptCachedPageData v2.1 (added added bug URL) I've neglected adding the bug URL in the previous attachment -- fixed.
Geoffrey Garen
Comment 4 2008-12-18 12:58:23 PST
Comment on attachment 26055 [details] ScriptCachedPageData v2.1 (added added bug URL) r=me
Darin Fisher (:fishd, Google)
Comment 5 2008-12-18 13:21:52 PST
http://trac.webkit.org/changeset/39379
Note You need to log in before you can comment on or make changes to this bug.