| Summary: | makeWeakPtr should support Ref and RefPtr as the argument | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, ews-watchlist, ggaren, webkit-bug-importer, wenson_hsieh, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2021-07-28 16:47:17 PDT
Created attachment 434475 [details]
Patch
Comment on attachment 434475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434475&action=review r=mews > Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:370 > + Ref baseObject = BaseObjectWithRefAndWeakPtr::create(); Nit - auto? (In reply to Wenson Hsieh from comment #2) > Comment on attachment 434475 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434475&action=review > > r=mews > > > Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:370 > > + Ref baseObject = BaseObjectWithRefAndWeakPtr::create(); > > Nit - auto? Oh, I wanted to explicitly name Ref here since I have tests for RefPtr as well as Ref. Committed r280414 (240054@main): <https://commits.webkit.org/240054@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434475 [details]. |