Bug 228563

Summary: [ews-build.webkit.org] Verify GitHub integrity in commit queue
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230095
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Jonathan Bedard 2021-07-28 12:43:58 PDT 
We need to more quickly detect cases where a our GitHub mirror isn't correct because of a mistake git-svn has made. We have a script to detect this already, we just need to run it in automation.
Comment 1 Radar WebKit Bug Importer 2021-07-28 12:44:15 PDT 
<rdar://problem/81230685>
Comment 2 Jonathan Bedard 2021-07-28 12:47:48 PDT 
Created attachment 434450 [details]
Patch
Comment 3 Jonathan Bedard 2021-07-28 13:22:31 PDT 
Created attachment 434454 [details]
Patch
Comment 4 Aakash Jain 2021-07-28 13:27:50 PDT 
Comment on attachment 434454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434454&action=review

> Tools/CISupport/ews-build/steps.py:3454
> +class VerifyGitHubIntegrity(steps.ShellSequence):

Maybe we should add a FIXME here for stop running it after we fully move to git
Comment 5 Jonathan Bedard 2021-07-28 13:28:36 PDT 
(In reply to Aakash Jain from comment #4)
> Comment on attachment 434454 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434454&action=review
> 
> > Tools/CISupport/ews-build/steps.py:3454
> > +class VerifyGitHubIntegrity(steps.ShellSequence):
> 
> Maybe we should add a FIXME here for stop running it after we fully move to
> git

Good idea on the FIXME, will add
Comment 6 Jonathan Bedard 2021-07-28 13:31:49 PDT 
Created attachment 434456 [details]
Patch for landing
Comment 7 EWS 2021-07-28 14:36:34 PDT 
Committed r280399 (240040@main): <https://commits.webkit.org/240040@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434456 [details].