Bug 228551

Summary: NetworkRTCUDPSocketCocoaConnections nw_listener_set_state_changed_handler callback should hold a reference to its listener
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, markericc02, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2021-07-28 06:13:09 PDT
<rdar://81137047>
Attachments
Patch (3.52 KB, patch)
2021-07-28 06:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.52 KB, patch)
2021-07-28 23:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-28 06:13:26 PDT
<rdar://problem/81213617>
Radar WebKit Bug Importer
Comment 2 2021-07-28 06:13:44 PDT
<rdar://problem/81213635>
youenn fablet
Comment 3 2021-07-28 06:13:50 PDT
<rdar://81137047>
youenn fablet
Comment 4 2021-07-28 06:28:20 PDT
Created attachment 434426 [details] Patch
Alex Christensen
Comment 5 2021-07-28 09:11:45 PDT
Comment on attachment 434426 [details] Patch Does it enter the cancelled state if it is destroyed before it transitions to the ready state? I think you could also use a WeakObjCPtr.
youenn fablet
Comment 6 2021-07-28 09:14:46 PDT
(In reply to Alex Christensen from comment #5) > Comment on attachment 434426 [details] > Patch > > Does it enter the cancelled state if it is destroyed before it transitions > to the ready state? I think you could also use a WeakObjCPtr. Cancelled state is guaranteed to happen whenever cancel is called, even if state is failed or not ready.
youenn fablet
Comment 7 2021-07-28 23:46:41 PDT
Created attachment 434502 [details] Patch for landing
EWS
Comment 8 2021-07-29 04:21:33 PDT
Committed r280420 (240060@main): <https://commits.webkit.org/240060@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434502 [details].
Note You need to log in before you can comment on or make changes to this bug.