Bug 228551

Summary: NetworkRTCUDPSocketCocoaConnections nw_listener_set_state_changed_handler callback should hold a reference to its listener
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, markericc02, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2021-07-28 06:13:09 PDT 
<rdar://81137047>
Comment 1 Radar WebKit Bug Importer 2021-07-28 06:13:26 PDT 
<rdar://problem/81213617>
Comment 2 Radar WebKit Bug Importer 2021-07-28 06:13:44 PDT 
<rdar://problem/81213635>
Comment 3 youenn fablet 2021-07-28 06:13:50 PDT 
<rdar://81137047>
Comment 4 youenn fablet 2021-07-28 06:28:20 PDT 
Created attachment 434426 [details]
Patch
Comment 5 Alex Christensen 2021-07-28 09:11:45 PDT 
Comment on attachment 434426 [details]
Patch

Does it enter the cancelled state if it is destroyed before it transitions to the ready state?  I think you could also use a WeakObjCPtr.
Comment 6 youenn fablet 2021-07-28 09:14:46 PDT 
(In reply to Alex Christensen from comment #5)
> Comment on attachment 434426 [details]
> Patch
> 
> Does it enter the cancelled state if it is destroyed before it transitions
> to the ready state?  I think you could also use a WeakObjCPtr.

Cancelled state is guaranteed to happen whenever cancel is called, even if state is failed or not ready.
Comment 7 youenn fablet 2021-07-28 23:46:41 PDT 
Created attachment 434502 [details]
Patch for landing
Comment 8 EWS 2021-07-29 04:21:33 PDT 
Committed r280420 (240060@main): <https://commits.webkit.org/240060@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434502 [details].