| Summary: | [Cg] Canvas fill() draws gradients even without a path | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | ||||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dirk Schulze
2008-12-13 07:26:02 PST
Created attachment 25999 [details]
example
an example. you should see a green box.
Created attachment 26000 [details]
fixes canvas gradient on cg
just don't call GraphicsContext::fillPath() or GraphicsContext::strokePath() if the path is empty.
Comment on attachment 26000 [details]
fixes canvas gradient on cg
r=me
One pixel-test fails. I'm prety sure that this failing pixel-test is wrong and should be deleted. It makes no sense to fill somthing with a gradient if the path is empty. This behavior is against the spec of HTML 5. It was added in https://bugs.webkit.org/show_bug.cgi?id=14642 becauses of http://adam.yanalunas.com/projects/reflect/. It could be that we didn't get fillRect to work with gradients at this time. To get reflect back, just delete the webkit hack on the script. Created attachment 26004 [details]
delete wrong pixel-test gradient-emty-path
delete wrong test.
|