Bug 22842 – [Gtk] Top offsets of elements in DumpRenderTree are incorrect

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Zan Dobersek]

Element's top offset values when running the tests through DumpRenderTree differ from those when viewing test in GtkLauncher.

A proof-of-problem patch to come.

[Zan Dobersek]

Created attachment 25997 [details]
Patch for reproducing the problem

This patch works with tests for SVG dynamic updates.

Through all these tests, the two outputs seem to be constant:
- when viewing any test in GtkLauncher, top offset is 66,
- when running any test in DRT, top offset is 311.
Left offset is always 8.

The difference occurs in RenderObject's offsetTop function, more precisely in this iteration[1] - it goes through one loop, in which curr is a RenderObject with #document node and is not a table row.
His yPos() is then added to y. In GtkLauncher, 58 is added to y, while in DRT y is increased by 303.
y then increases to the final value when offsetPar is recognized as a body and adds its yPos() (which equals to 8) to the y variable.

[1] http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderObject.cpp#L538

[Zan Dobersek]

Created attachment 26279 [details]
Fix - move size allocation to a proper place

As it turns out, the problem is solved with a proper placement of widget's size allocation.

At the moment, size allocation is done at dumping, when testing is already done. However, it should be done before loading the test in the WebKitWebView.

Patch changes this.

[Holger Freyther]

Landed in r39529.