Bug 228336 – Fix for [WebAccessibilityObjectWrapper lineRectsAndText] to properly handle replacement nodes and SVG text.

• Component: Accessibility
• Status: RESOLVED FIXED

[Andres Gonzalez]

Fix for [WebAccessibilityObjectWrapper lineRectsAndText] to properly handle replacement nodes and SVG text.

[Radar WebKit Bug Importer]

<rdar://problem/81172124>

[Andres Gonzalez]

Created attachment 434300 [details]
Patch

[Darin Adler]

Comment on attachment 434300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434300&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2881
> +                [text appendAttributedString:[[NSAttributedString alloc] initWithString:label]];

This isn’t ARC, so I think the leaks the attributed string. Need to release it.

[Andres Gonzalez]

Created attachment 434479 [details]
Patch

[Andres Gonzalez]

(In reply to Darin Adler from comment #3)
> Comment on attachment 434300 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434300&action=review
> 
> > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2881
> > +                [text appendAttributedString:[[NSAttributedString alloc] initWithString:label]];
> 
> This isn’t ARC, so I think the leaks the attributed string. Need to release
> it.

Thanks, I changed it to:

                auto label = adoptNS([[NSAttributedString alloc] initWithString:static_cast<WebAccessibilityObjectWrapper *>(item).accessibilityLabel]);
                [text appendAttributedString:label.get()];

[Andres Gonzalez]

Created attachment 434653 [details]
Patch

[Andres Gonzalez]

Created attachment 434705 [details]
Patch

[EWS]

Committed r280529 (240161@main): <https://commits.webkit.org/240161@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434705 [details].