Summary: | Fix for [WebAccessibilityObjectWrapper lineRectsAndText] to properly handle replacement nodes and SVG text. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||||||
Component: | Accessibility | Assignee: | Andres Gonzalez <andresg_22> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Andres Gonzalez
2021-07-27 11:13:19 PDT
Created attachment 434300 [details]
Patch
Comment on attachment 434300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434300&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2881 > + [text appendAttributedString:[[NSAttributedString alloc] initWithString:label]]; This isn’t ARC, so I think the leaks the attributed string. Need to release it. Created attachment 434479 [details]
Patch
(In reply to Darin Adler from comment #3) > Comment on attachment 434300 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434300&action=review > > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2881 > > + [text appendAttributedString:[[NSAttributedString alloc] initWithString:label]]; > > This isn’t ARC, so I think the leaks the attributed string. Need to release > it. Thanks, I changed it to: auto label = adoptNS([[NSAttributedString alloc] initWithString:static_cast<WebAccessibilityObjectWrapper *>(item).accessibilityLabel]); [text appendAttributedString:label.get()]; Created attachment 434653 [details]
Patch
Created attachment 434705 [details]
Patch
Committed r280529 (240161@main): <https://commits.webkit.org/240161@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434705 [details]. |