Bug 228335

Summary:

[build.webkit.org] Simulator temp files filling up disk

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, jenner, ryanhaddad, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	jbedard: commit-queue+

Description Jonathan Bedard 2021-07-27 11:07:17 PDT

We have a bunch of temp files for our simulators filling up disk space, we should delete them between runs.

Comment 1 Radar WebKit Bug Importer 2021-07-27 11:07:40 PDT

<rdar://problem/81171840>

Comment 2 Jonathan Bedard 2021-07-27 11:09:45 PDT

Created attachment 434298 [details]
Patch

Comment 3 Jonathan Bedard 2021-07-27 16:39:18 PDT

Created attachment 434385 [details]
Patch

Comment 4 Aakash Jain 2021-07-27 16:42:49 PDT

Comment on attachment 434385 [details]
Patch

rs=me

Comment 5 Jonathan Bedard 2021-07-27 16:46:17 PDT

Comment on attachment 434385 [details]
Patch

Letting EWS chew on it before landing, the last version unexpectedly gave EWS problems.

Comment 6 EWS 2021-07-27 17:47:10 PDT

Committed r280365 (240012@main): <https://commits.webkit.org/240012@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434385 [details].

Comment 7 Alexey Proskuryakov 2021-07-27 18:07:48 PDT

Comment on attachment 434385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434385&action=review

> Tools/CISupport/kill-old-processes:176
> +        os.system('find /private/var/folders -name "Deleting-*" -maxdepth 4 -exec sudo rm -rf {} +')

This should be using $TMPDIR.

As discussed elsewhere, we should investigate why these are not getting deleted. It's quite possibly our own fault.

Comment 8 Jonathan Bedard 2021-07-27 19:45:15 PDT

(In reply to Alexey Proskuryakov from comment #7)
> Comment on attachment 434385 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434385&action=review
> 
> > Tools/CISupport/kill-old-processes:176
> > +        os.system('find /private/var/folders -name "Deleting-*" -maxdepth 4 -exec sudo rm -rf {} +')
> 
> This should be using $TMPDIR.
> 
> As discussed elsewhere, we should investigate why these are not getting
> deleted. It's quite possibly our own fault.

My hope is that this is just temporary, if it's not, I'll go back to add TMPDIR.

Comment 9 Jonathan Bedard 2021-07-27 19:46:21 PDT

(re-opening this bug because it wasn't a permanent fix)

Comment 10 Jonathan Bedard 2021-08-03 13:42:38 PDT

Created attachment 434859 [details]
Patch

Comment 11 EWS 2021-08-03 16:14:53 PDT

Committed r280621 (240234@main): <https://commits.webkit.org/240234@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434859 [details].