Bug 228303

Summary:

Web Inspector: [Cocoa] "RemoteInspector XPC connection to relay failed." messages are confusing in StdErr

Product:

WebKit

Reporter:

Patrick Angle <pangle>

Component:

Web Inspector

Assignee:

Patrick Angle <pangle>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

226539

Bug Blocks:

228555

Attachments:

Description	Flags
Patch v1.0	none
Patch v1.1 - Use os_log to keep loging	none
Patch v1.2 - Revert to v1.0 approach, prepare to land	none

Description Patrick Angle 2021-07-26 15:00:45 PDT

There are many circumstances in which we expect the conditions that cause this logging to be encountered, and we shouldn't be `WTFLogAlways`ing for it, as that then puts the message in StdErr, creating confusing output when investigating often unrelated issues.

Comment 1 Radar WebKit Bug Importer 2021-07-26 15:00:58 PDT

<rdar://problem/81132233>

Comment 2 Patrick Angle 2021-07-26 15:04:05 PDT

Created attachment 434245 [details]
Patch v1.0

Comment 3 Patrick Angle 2021-07-27 11:37:44 PDT

<rdar://80395793>

Comment 4 Patrick Angle 2021-07-27 11:39:30 PDT

Created attachment 434302 [details]
Patch v1.1 - Use os_log to keep loging

Comment 5 Patrick Angle 2021-07-27 16:07:02 PDT

There are remaining questions and confusion surrounding use of os_log, so for now falling back to Darin's r+ yesterday on a patch to just remove the offending logging. I'll open a new bug to reintroduce this logging.

Comment 6 Patrick Angle 2021-07-27 16:12:56 PDT

Created attachment 434379 [details]
Patch v1.2 - Revert to v1.0 approach, prepare to land

Comment 7 EWS 2021-07-27 19:32:56 PDT

Committed r280370 (240017@main): <https://commits.webkit.org/240017@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434379 [details].