Bug 228294

Summary: Attribution context causes some performance regressions
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Kate Cheney 2021-07-26 12:33:21 PDT 
Attribution context causes some performance regressions
Comment 1 Kate Cheney 2021-07-26 12:34:16 PDT 
Created attachment 434225 [details]
Patch
Comment 2 Per Arne Vollan 2021-07-26 12:45:54 PDT 
Comment on attachment 434225 [details]
Patch

R=me.
Comment 3 EWS 2021-07-26 13:40:16 PDT 
Committed r280311 (239961@main): <https://commits.webkit.org/239961@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434225 [details].
Comment 4 Radar WebKit Bug Importer 2021-07-26 13:41:16 PDT 
<rdar://problem/81127864>
Comment 5 Darin Adler 2021-07-26 14:21:22 PDT 
Comment on attachment 434225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434225&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:61
>  static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest *) { };
> +static void overrideAttributionContext(NSMutableURLRequest *) { };

These semicolons should not be here.
Comment 6 Kate Cheney 2021-07-26 14:30:50 PDT 
Reopening to attach new patch.
Comment 7 Kate Cheney 2021-07-26 14:30:52 PDT 
Created attachment 434241 [details]
Patch for landing
Comment 8 EWS 2021-07-26 14:59:22 PDT 
Committed r280317 (239965@main): <https://commits.webkit.org/239965@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434241 [details].
Comment 9 Kate Cheney 2021-07-26 15:00:20 PDT 
(In reply to Darin Adler from comment #5)
> Comment on attachment 434225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434225&action=review
> 
> > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:61
> >  static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest *) { };
> > +static void overrideAttributionContext(NSMutableURLRequest *) { };
> 
> These semicolons should not be here.

Thanks, fixed it in a followup.