Bug 228266

Summary: [GTK] USE_OPENGL_OR_ES should not be an automagic feature
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, ews-watchlist, fujii.hironori, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2021-07-24 08:24:25 PDT
The USE_OPENGL_OR_ES feature flag added in r271220 is currently automagic: that is, if neither OpenGL nor OpenGL ES is available at build time, it gets silently disabled. This is not OK because it makes it easy for distributors to accidentally fail to enable OpenGL support. We should require manually disabling the feature with -DUSE_OPENGL_OR_ES=OFF in order to build with OpenGL disabled.
Attachments
Patch (2.69 KB, patch)
2021-07-24 08:37 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2021-07-24 08:27:03 PDT
Note that automagic detection of OpenGL ES is OK because that is not a "feature." It doesn't matter to the user whether OpenGL or OpenGL ES gets used under the hood. But it matters very much if neither is used at all.
Michael Catanzaro
Comment 2 2021-07-24 08:37:04 PDT
Created attachment 434169 [details] Patch
Fujii Hironori
Comment 3 2021-07-24 15:06:34 PDT
Comment on attachment 434169 [details] Patch It's my mistake. Thank you.
Michael Catanzaro
Comment 4 2021-07-25 10:59:55 PDT
Comment on attachment 434169 [details] Patch No problem. Build options are hard....
EWS
Comment 5 2021-07-25 11:29:34 PDT
Committed r280287 (239945@main): <https://commits.webkit.org/239945@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434169 [details].
Note You need to log in before you can comment on or make changes to this bug.