Summary: | [GTK] USE_OPENGL_OR_ES should not be an automagic feature | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, bugs-noreply, ews-watchlist, gyuyoung.kim, Hironori.Fujii, mcatanzaro, ryuan.choi, sergio | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2021-07-24 08:24:25 PDT
Note that automagic detection of OpenGL ES is OK because that is not a "feature." It doesn't matter to the user whether OpenGL or OpenGL ES gets used under the hood. But it matters very much if neither is used at all. Created attachment 434169 [details]
Patch
Comment on attachment 434169 [details]
Patch
It's my mistake. Thank you.
Comment on attachment 434169 [details]
Patch
No problem. Build options are hard....
Committed r280287 (239945@main): <https://commits.webkit.org/239945@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434169 [details]. |