Bug 228239

Summary: [Cocoa] Playback stalls on bilibili.com
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jean-yves.avenard, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing none

Description Jer Noble 2021-07-23 11:15:25 PDT
[Cocoa] Playback stalls on bilibili.com
Comment 1 Jer Noble 2021-07-23 11:16:24 PDT
<rdar://80419477>
Comment 2 Jer Noble 2021-07-23 11:39:47 PDT
Created attachment 434105 [details]
Patch
Comment 3 Jer Noble 2021-07-23 11:50:43 PDT
Created attachment 434106 [details]
Patch
Comment 4 Jer Noble 2021-07-23 11:54:11 PDT
Created attachment 434107 [details]
Patch
Comment 5 Eric Carlson 2021-07-26 10:31:11 PDT
Comment on attachment 434107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434107&action=review

> Source/WebCore/ChangeLog:18
> +        To make the call less ambiguous, add a MediaPlayer and MediaPlayerPrivate effectiveRate

Nit: you should pull the "()" back to the previous line
Comment 6 Jer Noble 2021-07-26 10:57:10 PDT
Created attachment 434215 [details]
Patch for landing
Comment 7 EWS 2021-07-26 12:36:59 PDT
Committed r280308 (239958@main): <https://commits.webkit.org/239958@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434215 [details].