Bug 228236

Summary: [macOS] Reduce sandbox logging
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Description Per Arne Vollan 2021-07-23 08:25:59 PDT
Reduce the sandbox logging on macOS.
Comment 1 Per Arne Vollan 2021-07-23 08:27:58 PDT
Created attachment 434089 [details]
Patch
Comment 2 Tim Horton 2021-07-23 11:28:57 PDT
Comment on attachment 434089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434089&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1425
> -(allow mach-lookup (with report)

did you mean to lose (with report) here?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1460
> -        (with report) (with telemetry-backtrace)

did you mean to lose (with report) here?
Comment 3 Tim Horton 2021-07-23 11:29:13 PDT
Comment on attachment 434089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434089&action=review

> Source/WebKit/ChangeLog:9
> +

A few more words would be great
Comment 4 Per Arne Vollan 2021-07-23 11:30:18 PDT
(In reply to Tim Horton from comment #2)
> Comment on attachment 434089 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434089&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1425
> > -(allow mach-lookup (with report)
> 
> did you mean to lose (with report) here?
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1460
> > -        (with report) (with telemetry-backtrace)
> 
> did you mean to lose (with report) here?

Yes, this is to avoid the cost of generating reports.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2021-07-23 11:30:30 PDT
(In reply to Tim Horton from comment #3)
> Comment on attachment 434089 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434089&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +
> 
> A few more words would be great

Will fix!
Comment 6 Per Arne Vollan 2021-07-23 11:36:24 PDT
Created attachment 434104 [details]
Patch
Comment 7 EWS 2021-07-23 12:57:31 PDT
Committed r280254 (239921@main): <https://commits.webkit.org/239921@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434104 [details].
Comment 8 Radar WebKit Bug Importer 2021-07-23 12:58:14 PDT
<rdar://problem/81032767>