Summary: | [Win] Crash under FontCache::lastResortFallbackFont | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bfulgham, ews-watchlist, Hironori.Fujii, mmaxfield, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=229009 | ||||||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2021-07-22 09:35:41 PDT
Created attachment 434015 [details]
Patch
Created attachment 434630 [details]
Patch
Created attachment 434766 [details]
Patch
Created attachment 434902 [details]
Patch
Comment on attachment 434902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434902&action=review > Source/WebKitLegacy/win/WebView.cpp:1327 > + if (hdc) { I wonder if we should just have an early return if hdc is blank? But this is fine as-is. Created attachment 435874 [details]
Patch
(In reply to Per Arne Vollan from comment #7) > Created attachment 435874 [details] > Patch Though it ultimately passed on retry, it looks like the Win EWS run had a flaky crash, is this related to the patch? https://ews-build.s3-us-west-2.amazonaws.com/Windows-EWS/r435874-101940-rerun/fast/forms/input-placeholder-paint-order-crash-log.txt Created attachment 436006 [details]
Patch
(In reply to Ryan Haddad from comment #8) > (In reply to Per Arne Vollan from comment #7) > > Created attachment 435874 [details] > > Patch > Though it ultimately passed on retry, it looks like the Win EWS run had a > flaky crash, is this related to the patch? > > https://ews-build.s3-us-west-2.amazonaws.com/Windows-EWS/r435874-101940- > rerun/fast/forms/input-placeholder-paint-order-crash-log.txt I think this should be resolved in the latest WIP patch. Thanks for reviewing! Comment on attachment 436006 [details]
Patch
Thanks for reviewing!
Committed r281380 (240795@main): <https://commits.webkit.org/240795@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436006 [details]. |